[code health] refactor builder entry checks to independent function #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
β Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #498 +/- ##
==========================================
+ Coverage 31.40% 31.68% +0.28%
==========================================
Files 24 24
Lines 4853 4860 +7
==========================================
+ Hits 1524 1540 +16
+ Misses 3136 3128 -8
+ Partials 193 192 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
metachris
reviewed
Aug 4, 2023
| @@ -1563,6 +1563,38 @@ func (api *RelayAPI) checkSubmissionSlotDetails(w http.ResponseWriter, log *logr | |||
| return true | |||
| } | |||
|
|
|||
| func (api *RelayAPI) checkBuilderEntry(w http.ResponseWriter, log *logrus.Entry, builderPubkey phase0.BLSPubKey) (*blockBuilderCacheEntry, bool) { | |||
There was a problem hiding this comment.
quick function comment would be nice, in particular what's the bool return value
metachris
approved these changes
Aug 4, 2023
This was referenced Aug 29, 2023
This was referenced Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
Pull the slot details checks into an independent function.
Part of series: #479, #491, #494.
β I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md