Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(redis): rename tx to pipeliner #499

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

alextes
Copy link
Contributor

@alextes alextes commented Aug 4, 2023

"transaction" is exactly what we shouldn't call the pipeliner. Redis offers both, the latter differs precisely in that it is not atomic.

  • make lint. (a lot of depguard errors, but not related to these changes.)
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

"transaction" is exactly what we shouldn't call the pipeliner. Redis
offers both, the latter differs precisely in that it is not atomic.
@codecov-commenter
Copy link

Codecov Report

Merging #499 (4d54559) into main (753275c) will increase coverage by 0.81%.
Report is 6 commits behind head on main.
The diff coverage is 91.83%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #499      +/-   ##
==========================================
+ Coverage   30.58%   31.40%   +0.81%     
==========================================
  Files          24       24              
  Lines        4783     4853      +70     
==========================================
+ Hits         1463     1524      +61     
- Misses       3121     3136      +15     
+ Partials      199      193       -6     
Flag Coverage Δ
unittests 31.40% <91.83%> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
datastore/redis.go 60.20% <91.30%> (ø)
datastore/utils.go 80.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

@metachris metachris merged commit e0d1248 into flashbots:main Sep 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants