Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive in boolean flag #500

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Fix false positive in boolean flag #500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion datastore/redis.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,6 @@ func (r *RedisCache) SaveBidAndUpdateTopBid(ctx context.Context, tx redis.Pipeli
if err != nil {
return state, err
}
state.WasBidSaved = true
builderBids.bidValues[payload.BuilderPubkey().String()] = payload.Value()

// Record time needed to save bid
Expand Down Expand Up @@ -543,6 +542,8 @@ func (r *RedisCache) SaveBidAndUpdateTopBid(ctx context.Context, tx redis.Pipeli
return state, err
}
state.IsNewTopBid = payload.Value().Cmp(state.TopBidValue) == 0
// An Exec happens in _updateTopBid.
state.WasBidSaved = true

// Record time needed to update top bid
nextTime = time.Now().UTC()
Expand Down
Loading