Add feature flags for backwards compatibility #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #521 +/- ##
==========================================
- Coverage 33.23% 33.19% -0.04%
==========================================
Files 24 24
Lines 5079 5097 +18
==========================================
+ Hits 1688 1692 +4
- Misses 3173 3186 +13
- Partials 218 219 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📢 Have feedback on the report? Share it here. |
metachris
reviewed
Sep 8, 2023
avalonche
force-pushed
the
add-feature-flags
branch
from
3b1ad6a
to
10010d7
Compare
metachris
reviewed
Sep 9, 2023
metachris
reviewed
Sep 9, 2023
metachris
reviewed
Sep 9, 2023
michaelneuder
pushed a commit
that referenced
this pull request
Sep 21, 2023
* Add feature flags for backwards compatibility * improve readability of flags * renaming flags * remove fork schedule checks and flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Adds two feature flags to maintain backwards compatibility with older CL clients.
⛱ Motivation and Context
New features were recently added which breaks compatibility with older clients. This PR adds feature flags allowing toggling via env vars to switch between the features:
USE_V2_PUBLISH_BLOCK_ENDPOINT- this toggles using the v2 endpoint on CL clients to publish blocks. This endpoint includes equivocation checks to prevent equivocation attacks. The latest prysm and lighthouse releases has not been tested thoroughly for the v2 endpoint, so the default for this flag is using the v1 endpoint.📚 References
✅ I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md