website custom data origin #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #549 +/- ##
=======================================
Coverage 33.26% 33.26%
=======================================
Files 24 24
Lines 5090 5090
=======================================
Hits 1693 1693
Misses 3178 3178
Partials 219 219
Flags with carried forward coverage won't be shown. Click here to find out more. |
avalonche
reviewed
Oct 31, 2023
avalonche
previously approved these changes
Oct 31, 2023
Co-authored-by: shana <[email protected]>
avalonche
approved these changes
Oct 31, 2023
avalonche
added a commit
that referenced
this pull request
Oct 31, 2023
* add LinkDataAPI env to website service * fix env name * fix env name * fix payload link * add website env to readme * Update README.md Co-authored-by: shana <[email protected]> --------- Co-authored-by: shana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
adds the ability to control, via environment variable, the origin of the data api hyperlinks in the website service.
⛱ Motivation and Context
allows operators to run the data api on a different endpoint or port from the website service.
✅ I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md