fix(startup): Remove static_file_provider checks create_provider_factory #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR removes the calls to
static_file_provider().get_highest_static_file_block(..)
since it appears we no longer actively use the static file provider in our code.💡 Motivation and Context
As far as I can tell, we no longer really use the static_file_provider inside the
ProviderFactoryReopener
, but the check increate_provider_factory
causes circular dependencies related to #199 or ethpandaops/ethereum-package#786.✅ I have completed the following steps:
make lint
make test