Allow negative coinbase profit in Order::Tx
and Order::Bundle
#233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When disallowed for all
Order
varients, the coinbase account has no way to spend funds when rbuilder is building all blocks for a chain.Instead of using saturating_sub, I also tried changing
coinbase_profit
from aU256
to anI256
, but ran into issues where aU256
is required to calculate stuff likemev_gas_price
in later logic. I'd prefer that approach if anyone knows if it is feasible.