Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip - don't merge] initial bundle sponsorship code #83

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bertmiller
Copy link
Member

@bertmiller bertmiller commented Jul 24, 2024

📝 Summary

This work starts to implement #25, bundle sponsorship. It shows how you can catch the InvalidTransaction::LackOfFundForMaxFee error and parse it to grab the necessary information to attempt a bundle sponsorship.

I started this PR months ago but didn't carry it out because at the time reth had a bug and was returning the wrong information. I am no longer actively working on it as my priorities have changed, so I'd encourage someone else to pick it up from here.

The next steps for this work:

  • Simulate sponsored bundles
  • Evaluate if they are profitable to sponsor and handle the results of simulation
  • Alter SimulatedOrder to include info about sponsorship if desirable
  • Parse and handle sponsored bundles when filling orders (e.g. by inserting a sponsor tx with the right nonce)

But I haven't thought it out thoroughly!

💡 Motivation and Context

See #25, we might want this because it allows us to execute some transactions and make fees from them that we otherwise wouldn't be able to - thus leading to more valuable blocks.


✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@bertmiller bertmiller added enhancement New feature or request help wanted Extra attention is needed wontfix This will not be worked on labels Jul 24, 2024
@bertmiller bertmiller linked an issue Jul 24, 2024 that may be closed by this pull request
Copy link

Benchmark results for cb298d6

Report: https://flashbots-rbuilder-ci-stats.s3.us-east-2.amazonaws.com/benchmark/cb298d6-ae24579/report/index.html

Date (UTC) 2024-07-24T18:01:53+00:00
Commit cb298d6c5f8a87c340abe077a158782e4b208c03
Base SHA ae24579813ba4eda3d5c5469f4a107900516d7ee

Significant changes

None

@chirag-bgh
Copy link
Contributor

Hey, I'm interested in implementing this feature. I would take this up from here.

@bertmiller bertmiller marked this pull request as draft October 1, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: bundle sponsorship
2 participants