chore(signature): Double-check signature logic using third-party tools. #152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
Adds two more unit tests for
flashbots.ParseSignature
using two signatures generated via MetaMask andcast
.β± Motivation and Context
I realized that the existing
TestParseSignature
test uses thecrypto
package to generate the signatures, and since this is the same package we use internally to verify the signatures it was possible that we had a bug in both our uses for generation and validation of the package. So as an extra sanity check I generated two additional signatures using MetaMask andcast
to confirm that our signature verification code works across multiple signature implementations.π References
I actually wasn't aware of this nice extra feature of etherscan where signatures can be published that also offers a nice UI for prompting your wallet to generate a signature: https://etherscan.io/verifiedSignatures#
β I have run these commands
make lint
make test
go mod tidy