fix: Compare local nonce w/ backend to detect invalidated cache #153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
If the user submits a tx via some pathway other than our rpc-endpoint (e.g. the public mempool or another private pool) then our cache of the users max nonce was not being invalidated.
β± Motivation and Context
Steps to reproduce:
eth_getTransactionCount
RPCThe fix:
Before returning nonce from cache, we still do a backend request as normal, if it returns a tx count greater than the one derived from our cache we return it instead and invalidate our cache.
π References
β I have run these commands
make lint
make test
go mod tidy