feat: add rocketmq-console login auth #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kongfei605
reviewed
Dec 24, 2024
kongfei605
reviewed
Dec 24, 2024
|
|
||
| func (ins *Instance) Login() (string, error) { | ||
| loginURL := fmt.Sprintf("%s/login/login.do", consoleSchema + ins.RocketMQConsoleIPAndPort) | ||
| data := url.Values{} |
kongfei605
reviewed
Dec 24, 2024
| req.Header.Set("Content-Type", "application/x-www-form-urlencoded") | ||
|
|
||
| // 获取 set-cookie 头 | ||
| cookies := res.Header.Get("Set-Cookie") |
There was a problem hiding this comment.
这里的代码被误删了
res, err := http.DefaultClient.Do(req)
if err != nil {
return "", err
}
# Conflicts: # inputs/rocketmq_offset/rocketmq.go
|
Thank you @waynedream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rocketmq-offset插件支持登录认证功能，rocketmq-console在开启登录认证时，原插件无法直接调用接口获取信息，需要先请求login接口获取cookie
rocketmq_offset.toml 配置文件中增加username 和 password 字段
如果配置了账号密码，会先请求登录接口，如果没配置账号密码，还是和原逻辑一样
例子：
collect interval
interval = 15
[[instances]]
rocketmq_console_ip_port="127.0.0.1:8080"
username="admin"
password="123456"
ignored_topics=[]