fix:http_response headers concurrent map writes and add dial remote addr #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kongfei605
reviewed
Feb 7, 2024
| if err != nil { | ||
| return nil, err | ||
| } | ||
| //proxy, err := ins.Proxy() |
kongfei605
reviewed
Feb 7, 2024
| @@ -242,12 +242,7 @@ func (ins *Instance) httpGather(target string) (map[string]string, map[string]in | |||
| return nil, nil, err | |||
| } | |||
|
|
|||
| // compatible with old config | |||
| for i := 0; i < len(ins.Headers); i += 2 { | |||
There was a problem hiding this comment.
这些都去掉，老版本客户配置的headers 不要了？
There was a problem hiding this comment.
这个headers 有并发安全问题,原来就有一个httpConfig 的headers,不知道为啥多加了一层headers,还和原来结构不一致
There was a problem hiding this comment.
instance的header是老的用法，http common config中的header 是map格式，配置起来会更简单（其他插件有用到的）
|
这个插件先不要这么改，应该借鉴black box的逻辑，像cookie 、fllow redirection都支持 |
kongfei605
reviewed
Feb 8, 2024
| @@ -38,7 +37,7 @@ targets = [ | |||
| # password = "pa$$word" | |||
|
|
|||
| ## Optional headers | |||
| # headers = ["Header-Key-1", "Header-Value-1", "Header-Key-2", "Header-Value-2"] | |||
| # headers = { "Accept-Encoding" = "Gzip" } | |||
There was a problem hiding this comment.
这个地方不建议修改。 这里用法是 配对使用，修改成这样，不容易看出来用法。
kongfei605
reviewed
Feb 8, 2024
| # use_tls = false | ||
| # use_tls = true | ||
| ## Set https conn remote addr(required use_tls) | ||
| # tls_remote_addr = "10.10.10.10:443" |
There was a problem hiding this comment.
看代码中应该是https_remote_addr
|
这个PR先close了， 后续借鉴black box的逻辑再重构一下，
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
headers没有必要重新定义,有map并发写问题
添加了http和https 建联ip指定的功能代替原生的proxy,解决https指定代理无法访问的问题