Add a note about int32/int64 datatypes to the kv_layout tutorial
#737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzh119
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Looks great, actually flashinfer supports int64 indices at CUDA side and we might enable them at Python side at some moment later, but let's merge this in first :) Thanks for the contribution @fergusfinn !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure the best place to put this, but this is where I was looking when i was experiencing the error in this issue.
Note might need to be removed if the library adds dispatch to kernels with idtype=int64, or type validation in the kernels.