coreos-base/update_engine: Fix keeping of needed Flatcar extensions #3353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulls in flatcar/update_engine#51 Signed-off-by: Kai Lueke <[email protected]>
pothos
force-pushed
the
kai/update-engine-postinst-fix
branch
from
fbb071d to
2fe32a6
Compare
When /etc way kept busy through, e.g., a process using it as CWD, then even in the temporary namespace unmounting failed unless it was done with the lazy option. This pulls in flatcar/update_engine#52 to address this. Signed-off-by: Kai Lueke <[email protected]>
pothos
force-pushed
the
kai/update-engine-postinst-fix
branch
from
ee112be to
7e37477
Compare
pothos
added a commit
that referenced
this pull request
Oct 14, 2025
coreos-base/update_engine: Fix keeping of needed Flatcar extensions
pothos
added a commit
that referenced
this pull request
Oct 14, 2025
coreos-base/update_engine: Fix keeping of needed Flatcar extensions
|
I didn't backport it to Stable or LTS because that requires either updating it to be aligned with the new Beta or do a backport branch where we would cherry pick. I think it's also ok to let it progress from Beta to Stable. |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/18486885764 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in flatcar/update_engine#51
coreos-base/update_engine: Fix opaque directory handling
When /etc way kept busy through, e.g., a process using it as CWD, then
even in the temporary namespace unmounting failed unless it was done
with the lazy option.
This pulls in flatcar-postinst: Use lazy unmount for /etc in temporary namespace update_engine#52 to
address this.
How to use
Backport
Testing done
Existing extension images (and the first one of two new downloaded) were correctly kept when updating to the new image with flatcar-update and the extensions passed in.
For testing I had to revert 61f3478 which causes a regression: flatcar/ue-rs#92
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.