Skip to content

Commit

Permalink
Merge pull request #425 from bbhtt/bbhtt/no-ext-data-appdata
Browse files Browse the repository at this point in the history
manifest: Skip updating appdata if last source is not external
  • Loading branch information
wjt authored Jun 10, 2024
2 parents e4b970e + cdabbc1 commit 9934810
Showing 1 changed file with 13 additions and 4 deletions.
17 changes: 13 additions & 4 deletions src/manifest.py
Original file line number Diff line number Diff line change
Expand Up @@ -486,10 +486,19 @@ def _update_appdata(self):
elif data.source_path == self._root_manifest_path:
selected_data = data
else:
# Guess that the last external source in the root manifest is the one
# corresponding to the main application bundle.
assert selected_data is not None
log.warning("Guessed upstream source: %s", selected_data)
if selected_data is not None:
# Guess that the last external source in the root manifest is the one
# corresponding to the main application bundle.
log.warning("Guessed last source as main source: %s", selected_data)
else:
log.error(
(
"No main source configured and no external source in "
"%s. Not updating appdata"
),
self._root_manifest_path,
)
return

last_update = selected_data.new_version

Expand Down

0 comments on commit 9934810

Please sign in to comment.