fixed the external data checker from stalling when git tag pattern is incorrect, this should fix the github actions run #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this does fix the problem. Nice work tracking this down! I'll amend your commit slightly for style. What I am trying to work out is: why does the assertion failure hang the asyncio loop forever? |
This will be used to replace some very similar code in gitchecker.
Rather than asserting when given the wrong number of match groups, this helper raises a descriptive exception. This is both more helpful to the developer who has incorrectly specified the tag-pattern, but also seems to prevent an issue where an assertion failure causes the asyncio mainloop to hang. Fixes #418 Thanks to Tobias Micheler <[email protected]> for finding the issue!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently opened a related issue:
This closes #418
In this issue I said, that I don't know how to fix this problem. However, I figured it out.