Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

externaldata: Error cleanly when source is missing required checksum #423

Merged
merged 1 commit into from
May 29, 2024
+13 −0
Merged

externaldata: Error cleanly when source is missing required checksum #423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/lib/externaldata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,19 @@ def from_source(
if not source.get("url"):
raise SourceUnsupported('Data is not external: no "url" property')

if (
source.get("type") == ExternalBase.Type.EXTRA_DATA
and "sha256" not in source
):
raise SourceLoadError("Extra data is missing SHA256 checksum")

if source.get("type") in (
ExternalBase.Type.FILE,
ExternalBase.Type.ARCHIVE,
):
if not (source.keys() & {"md5", "sha1", "sha256", "sha512"}):
raise SourceLoadError("Data is missing checksum")

# FIXME: https://github.com/python/mypy/issues/9282
return super().from_source(source_path, source, module) # type: ignore

Expand Down
Loading