Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New runtime #15

Closed
wants to merge 10 commits into from
Closed

New runtime #15

wants to merge 10 commits into from

Conversation

bztd
Copy link

@bztd bztd commented Sep 26, 2024

This commit fixes #3 and robertsanseries/ciano#146
Added missing fields to .appdata.xml
Updated ffmpeg
Updated the routine to 23.08
Added a patch for the icon names provided by the arclinux team.
Added a patch to fix a segmentation violation in certain circumstances and corrected the assignment of the path of the files to be converted (ConverterController.vala.patch).

The program works fine. I have tried some conversions, there is a bug with the gifs.

@flathubbot
Copy link

Started test build 149792

@flathubbot
Copy link

Build 149792 failed

@flathubbot
Copy link

Started test build 149805

@flathubbot
Copy link

Build 149805 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/132898/com.github.robertsanseries.ciano.flatpakref

@bztd
Copy link
Author

bztd commented Sep 26, 2024

@bbhtt could you review this petition

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this patch submitted upstream ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I don't know if it's the most aesthetic solution. I'll mention it in the respective bug report, so the developer can fix it.

@bztd bztd closed this Sep 28, 2024
@bztd bztd reopened this Sep 28, 2024
@flathubbot
Copy link

Started test build 150198

@flathubbot
Copy link

Build 150198 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/133289/com.github.robertsanseries.ciano.flatpakref

@flathubbot
Copy link

Started test build 150204

@flathubbot
Copy link

Build 150204 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/133295/com.github.robertsanseries.ciano.flatpakref

@bztd
Copy link
Author

bztd commented Oct 4, 2024

@bbhtt Is there any additional correction?

Comment on lines 90 to 96
"buildsystem": "simple",
"build-commands": [
"autoreconf -fiv",
"./configure --prefix=/app --disable-shared",
"make",
"make install"
],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use autotools instead of simple, you can add autoreconf -fiv as a shell source https://docs.flatpak.org/en/latest/module-sources.html#shell-and-script-sources

@bbhtt
Copy link

bbhtt commented Oct 5, 2024

It'd be easier to merge this if ConverterController.vala.patch is merged upstream. There is no active maintainer, so having extra patches complicates future maintenance when runtime needs to be bumped again.

@bztd
Copy link
Author

bztd commented Oct 5, 2024

The problem in my opinion is that the application looks bad, at least on my system, and the runtime is not updated. The patch in question is not related to the runtime, but to what ffmpeg returns. Since I have updated it, the error has occurred. The patch has a general approach and it is difficult for a new output in ffmpeg to break the execution. In that sense there is no patch related to the update of the runtime except for the patch to the issue which is easy to remedy by removing it. To keep the spirit of the package I think it is fine to leave it.
(This is a translation)

Change acc module buildsystem
@flathubbot
Copy link

Started test build 151979

@flathubbot
Copy link

Build 151979 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/135064/com.github.robertsanseries.ciano.flatpakref

@bztd bztd closed this by deleting the head repository Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme issue
3 participants