-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New runtime #15
New runtime #15
Conversation
Started test build 149792 |
Build 149792 failed |
Started test build 149805 |
Build 149805 successful
|
@bbhtt could you review this petition |
ConverterController.vala.patch
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this patch submitted upstream ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. I don't know if it's the most aesthetic solution. I'll mention it in the respective bug report, so the developer can fix it.
Started test build 150198 |
Build 150198 successful
|
Started test build 150204 |
Build 150204 successful
|
@bbhtt Is there any additional correction? |
"buildsystem": "simple", | ||
"build-commands": [ | ||
"autoreconf -fiv", | ||
"./configure --prefix=/app --disable-shared", | ||
"make", | ||
"make install" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should use autotools instead of simple, you can add autoreconf -fiv as a shell source https://docs.flatpak.org/en/latest/module-sources.html#shell-and-script-sources
It'd be easier to merge this if ConverterController.vala.patch is merged upstream. There is no active maintainer, so having extra patches complicates future maintenance when runtime needs to be bumped again. |
The problem in my opinion is that the application looks bad, at least on my system, and the runtime is not updated. The patch in question is not related to the runtime, but to what ffmpeg returns. Since I have updated it, the error has occurred. The patch has a general approach and it is difficult for a new output in ffmpeg to break the execution. In that sense there is no patch related to the update of the runtime except for the patch to the issue which is easy to remedy by removing it. To keep the spirit of the package I think it is fine to leave it. |
Change acc module buildsystem
Started test build 151979 |
Build 151979 successful
|
This commit fixes #3 and robertsanseries/ciano#146
Added missing fields to .appdata.xml
Updated ffmpeg
Updated the routine to 23.08
Added a patch for the icon names provided by the arclinux team.
Added a patch to fix a segmentation violation in certain circumstances and corrected the assignment of the path of the files to be converted (ConverterController.vala.patch).
The program works fine. I have tried some conversions, there is a bug with the gifs.