-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update General #16
base: master
Are you sure you want to change the base?
Update General #16
Conversation
Started test build 160206 |
Build 160206 successful
|
@barthalion @hfiguiere This pull request could be reviewed for merging. |
lots of unnecessary changes make it hard to review |
Just to clarify, the important patch (ConverterController.vala.patch
I thought of the patch trying to foresee that the output of ffmpeg may change or that the program may receive a uri or path, I tried to make it as robust as possible. Recently a fix was added that I think is simpler, but less robust in the ciano repository. |
Removing duplicate dependencies: libvpx, opus
Started test build 160457 |
Build 160457 successful
|
re-formatting .json
re-formatting .json
Started test build 162603 |
Build 162603 successful
|
This commit fixes #3 and robertsanseries/ciano#146
Added missing fields to .appdata.xml (com.github.robertsanseries.ciano.appdata.xml.in.patch).
fix ugly box in theme (elementary-theme.patch).
Updated ffmpeg
Updated the routine to 23.08
Added a patch for the icon names provided by the arclinux team (0001-Use-standard-icon-names.patch).
Added a patch to fix a segmentation violation in certain circumstances and corrected the assignment of the path of the files to be converted (ConverterController.vala.patch).
Patchs elementary-theme.patch,0001-Use-standard-icon-names.patch are cosmetic and can be removed, the rest is necessary for the program to work.
The program works fine. I have tried some conversions, there is a bug with the gifs(not unique to this build, reported by arch team, handled with a patch not applied here). https://gitlab.archlinux.org/archlinux/packaging/packages/ciano/-/tree/main?ref_type=heads