Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update General #16

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Update General #16

wants to merge 11 commits into from

Conversation

bztd
Copy link

@bztd bztd commented Nov 7, 2024

This commit fixes #3 and robertsanseries/ciano#146
Added missing fields to .appdata.xml (com.github.robertsanseries.ciano.appdata.xml.in.patch).
fix ugly box in theme (elementary-theme.patch).
Updated ffmpeg
Updated the routine to 23.08
Added a patch for the icon names provided by the arclinux team (0001-Use-standard-icon-names.patch).
Added a patch to fix a segmentation violation in certain circumstances and corrected the assignment of the path of the files to be converted (ConverterController.vala.patch).

Patchs elementary-theme.patch,0001-Use-standard-icon-names.patch are cosmetic and can be removed, the rest is necessary for the program to work.

The program works fine. I have tried some conversions, there is a bug with the gifs(not unique to this build, reported by arch team, handled with a patch not applied here). https://gitlab.archlinux.org/archlinux/packaging/packages/ciano/-/tree/main?ref_type=heads

@flathubbot
Copy link

Started test build 160206

@flathubbot
Copy link

Build 160206 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/143285/com.github.robertsanseries.ciano.flatpakref

@bztd
Copy link
Author

bztd commented Nov 8, 2024

@barthalion @hfiguiere This pull request could be reviewed for merging.

@hfiguiere
Copy link

lots of unnecessary changes make it hard to review

@bztd
Copy link
Author

bztd commented Nov 8, 2024

Just to clarify, the important patch (ConverterController.vala.patch
), fixes two problems.

  1. when looking for the file to convert the code expects a "path", but the code instruction is for a "uri".
  2. in some circumstances ffmpeg returns a string of characters that is not expected, causing it to point to a position outside the array where the string of characters is stored.

I thought of the patch trying to foresee that the output of ffmpeg may change or that the program may receive a uri or path, I tried to make it as robust as possible. Recently a fix was added that I think is simpler, but less robust in the ciano repository.

Removing duplicate dependencies: libvpx, opus
@flathubbot
Copy link

Started test build 160457

@flathubbot
Copy link

Build 160457 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/143535/com.github.robertsanseries.ciano.flatpakref

@flathubbot
Copy link

Started test build 162603

@flathubbot
Copy link

Build 162603 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/145677/com.github.robertsanseries.ciano.flatpakref

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme issue
3 participants