-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use PID in per-process D-Bus name (fixes #36, #374) #375
Conversation
Started test build 154728 |
Build 154728 successful
|
While submitting the patch here is fine for testing, we don't carry Flathub specific patches for KDE Apps so you will have to submit the patch for review at https://invent.kde.org/graphics/okular as well and to get it merged there first. |
Thanks for the patch. Can you split the finish-args changes into another PR? We should be able to merge those sooner. Thanks |
How would it print without access to the printing system? |
OP is referring to printing portal. You may see that similar app from gnome doesn't have cups permission. I don't know whether it works in okular. |
Okular does not use the printing portal. |
https://invent.kde.org/graphics/okular/-/merge_requests/1061
Okular uses standard Qt printing facilities if I'm not mistaken. I've no idea whether Qt supports the printing portal or not. File opening through portals is transparent after all. |
You are mistaken. |
Haven't done an analysis more comprehensive than a simple Out of curiosity, if Qt is not used, how does Okular print at all? Especially on Windows, which has no CUPS. |
OK, it paints onto |
You may propose changing that. This implementation is from 16 years ago. |
Probably makes sense to try to upstream the patch. Also, if I'm not mistaken, Qt printing does use XDG portals, which means that CUPS permission is probably unnecessary. May be someone can check whether it prints without
--socket=cups
?