Don't use PID in per-process D-Bus name (fixes #36, #374)

[nihil-admirari]

1. Use UUID instead of PID for per-process D-Bus name, see Flathub's Okular should use non-PID identifier on D-Bus or share a PID namespace for all instances #374 for details.
2. Per-process D-Bus was renamed to align with D-Bus naming conventions and to allow the use of D-Bus without granting blanket session D-Bus permission.

Probably makes sense to try to upstream the patch. Also, if I'm not mistaken, Qt printing does use XDG portals, which means that CUPS permission is probably unnecessary. May be someone can check whether it prints without --socket=cups?

[flathubbot]

Started test build 154728

[flathubbot]

Build 154728 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/137816/org.kde.okular.flatpakref

[travier]

While submitting the patch here is fine for testing, we don't carry Flathub specific patches for KDE Apps so you will have to submit the patch for review at https://invent.kde.org/graphics/okular as well and to get it merged there first.

[travier]

Thanks for the patch. Can you split the finish-args changes into another PR? We should be able to merge those sooner. Thanks

[tsdgeos]

May be someone can check whether it prints without --socket=cups?

How would it print without access to the printing system?

[Erick555]

OP is referring to printing portal. You may see that similar app from gnome doesn't have cups permission. I don't know whether it works in okular.

[tsdgeos]

Okular does not use the printing portal.

[nihil-admirari]

we don't carry Flathub specific patches for KDE Apps so you will have to submit the patch for review at https://invent.kde.org/graphics/okular as well and to get it merged there first

https://invent.kde.org/graphics/okular/-/merge_requests/1061

Can you split the finish-args changes into another PR?

#378

Okular does not use the printing portal.

Okular uses standard Qt printing facilities if I'm not mistaken. I've no idea whether Qt supports the printing portal or not. File opening through portals is transparent after all.

[tsdgeos]

Okular uses standard Qt printing facilities if I'm not mistaken

You are mistaken.

[nihil-admirari]

Haven't done an analysis more comprehensive than a simple grep, but it does show the use of QPrintDialog, QPrinter and other Qt classes.

Out of curiosity, if Qt is not used, how does Okular print at all? Especially on Windows, which has no CUPS.

[tsdgeos]

See https://invent.kde.org/graphics/okular/-/blob/master/generators/poppler/generator_pdf.cpp?ref_type=heads#L1498

[nihil-admirari]

OK, it paints onto QPrinter on Windows and on Linux it calls lpr.

[Erick555]

You may propose changing that. This implementation is from 16 years ago.