73 Get Pettingzoo example to work again. #102
Draft
+300
−1,375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeCroise
reviewed
Dec 15, 2024
flatland/ml/pettingzoo/examples/flatland_pettingzoo_stable_baselines.py
Outdated
Show resolved
Hide resolved
chenkins
changed the title
6 tasks
chenkins
force-pushed
the
74-policy-evaluation-and-training-cli
branch
3 times, most recently
from
48347b6 to
29fa6a6
Compare
chenkins
commented
Feb 16, 2025
| self.agents: list[AgentID] = self.wrap.get_agent_handles() | ||
| self.possible_agents: list[AgentID] = self.wrap.get_agent_handles() | ||
| self.observation_spaces: dict[AgentID, gym.spaces.Space] = { | ||
| # TODO bad smell: must be gymobservationbuilder |
flatland/ml/pettingzoo/wrappers.py
Outdated
| assert hasattr(wrap.obs_builder, "get_observation_space"), f"{type(wrap.obs_builder)} is not gym-compatible, missing get_observation_space" | ||
| self.wrap = wrap | ||
|
|
||
| # TODO should be AEC instead |
There was a problem hiding this comment.
AEC instead of parallel
chenkins
force-pushed
the
73-pettingzoo
branch
from
0e5d41d to
1dab10b
Compare
Base automatically changed from
74-policy-evaluation-and-training-cli
to
main
February 18, 2025 13:36
chenkins
force-pushed
the
73-pettingzoo
branch
from
1dab10b to
e46a28a
Compare
Signed-off-by: chenkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Related issues
Resolves #73.
Checklist
docsfolder for relevant behavior changes. If you made important user-facingchanges, describe them under the
[Unreleased]tag inCHANGELOG.md.pyproject.tomlfile.Requirement files have been updated by running
tox -e requirements.required to run successfully.
CONTRIBUTING.mdare followed.