Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add builder_id to builds #120

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jameswestman
Copy link
Collaborator

We can set a builder_id on a token, and that ID will be stored on every build created with that token. We'll use this in flat-manager-hooks to insert an appstream tag for apps built by buildbot.

We can set a builder_id on a token, and that ID will be stored on every
build created with that token.
@jameswestman jameswestman marked this pull request as draft August 9, 2023 16:39
@jameswestman
Copy link
Collaborator Author

Hmm, thinking about this a bit more... This plan assumes that you can't edit buildbot builds with a direct upload token, which isn't a sound assumption if we allow switching from buildbot to direct upload. This needs more design. Maybe if a build is created with a builder_id, it can only be edited by that builder_id?

@jameswestman
Copy link
Collaborator Author

Or we could track builder_id on the build ref instead of the whole build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant