Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert bare except to exceptions raised by json.loads() #133

Closed
wants to merge 1 commit into from
Closed

Convert bare except to exceptions raised by json.loads() #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions flat-manager-client
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class ApiError(Exception):

try:
self.body = json.loads(body)
except:
except (json.JSONDecodeError, TypeError):
self.body = {"status": self.status, "error-type": "no-error", "message": "No json error details from server"}

def repr(self):
Expand Down Expand Up @@ -581,7 +581,7 @@ async def publish_build(session, build_url, wait, token):
elif current_state == "validating":
print("the build is still being validated or held for review")
return {}
except:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bare except in particular would silently swallow the ApiError explicitly raised within the above try block.

except json.JSONDecodeError:
pass

if resp.status != 200:
Expand Down
Loading