Go: Completely rewrite #369
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfiguiere
reviewed
Sep 9, 2023
go/README.md
Outdated
| - dest: src/git/torproject/org/pluggable-transports/goptlib/git | ||
| tag: v1.1.0 | ||
| type: git | ||
| url: https://git.torproject.org/pluggable-transports/goptlib.git.git |
There was a problem hiding this comment.
shall the commit also be added to protect against retagging?
…re, and otherwise clone every git repo to find its commit id
…output to facilitate debugging
jgillich
reviewed
Jan 26, 2024
|
|
||
| os.chdir(temp_dir) | ||
|
|
||
| if folder: |
There was a problem hiding this comment.
I think this if is a mistake. When given a root dir such as github.com/a/b.git/, this script detects no dependencies because it never switches into the repo directory. When I comment this line, it works.
Also it'd be nice if we could just give it the git url without the slash
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing Flatpak Go Get Generator no longer works with the modern Go ecosystem. The flatpak-go-get-generator.py script works by looking for git repos in the Flatpak build dir after running
go get, but that doesn't even create git repos anymore.So this PR deletes the old
go-getfolder and makes a newgofolder. This requires that Go and git are installed on the local system.This script works by creating a new Go module in a temporary folder, add the given Go package as a dependency, and then runs
go list -m allto get the full list of Go modules. For each module, it usesgo list -m -json <module>to get detailed information. And then finally, it outputs the module in YAML format.