Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to handling of packages with caps #423

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

jonathon-love
Copy link
Contributor

Currently flatpak builder doesn't handle packages with caps in them properly. i.e. it does not generate the sources appropriately for, say, PyYAML.

@barthalion barthalion merged commit 9a48b5e into flatpak:master Oct 1, 2024
@dreua
Copy link
Contributor

dreua commented Oct 29, 2024

In which way did it generate the sources wrong?
In the case of pikepdf this change results in Deprecated (package name with capital D) vanishing from the generated sources. I now have to figure out if that should never have been there in the first place or if it is now missing due to the change.
https://github.com/dreua/flatpak-module-qpdf-pikepdf/pull/84/files

@dreua
Copy link
Contributor

dreua commented Oct 29, 2024

I think this is a regression, pikepdf now fails to build because Deprecated is missing in the newly generated dependencies.
Are you sure the keys in sources are casefolded? I guess they aren't but haven't run the debugger on it.

@bbhtt
Copy link
Contributor

bbhtt commented Oct 29, 2024

Try #429

dreua added a commit to dreua/flatpak-builder-tools that referenced this pull request Oct 29, 2024
dreua added a commit to dreua/flatpak-builder-tools that referenced this pull request Oct 29, 2024
@dreua
Copy link
Contributor

dreua commented Oct 29, 2024

I just came up with the very small change in #430 which works for me. Now I see #429 which looks a lot more complex. Not sure what issues it needs to solve though, maybe that complexity is necessary.

@dreua
Copy link
Contributor

dreua commented Oct 29, 2024

There is a difference in the x-checker-data, but the data checker doesn't seem to care:

         x-checker-data:
-          name: Deprecated [my version and the status quo before this regression]
+          name: deprecated [@bbhtt's version]

@bbhtt
Copy link
Contributor

bbhtt commented Oct 29, 2024

because you are lowercasing it in only one place - sources, anyway that doesn't cause any functional difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants