Default libdir for app is /app/lib #587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alatiera
reviewed
Feb 24, 2024
| @@ -1075,6 +1075,8 @@ builder_options_get_libdir (BuilderOptions *self, BuilderContext *context) | |||
|
|
|||
| if (builder_context_get_build_runtime (context)) | |||
| return get_sdk_flags (self, context, builder_sdk_config_get_libdir); | |||
| if (!builder_context_get_build_extension (context)) | |||
There was a problem hiding this comment.
I'd make it an else if just in case, but it's fine since we return on both anyway
|
I will close this for further work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flatpak-builder promises that libdir is /app/lib for apps but this is currently not really the case. Instead, flatpak-builder relies on patching of libdir on Meson and cmake and prefix being set to /app. Since it's not really up to runtime to select what libdir for apps is (this is defined in flatpak instead), instead add a default here.