Apply new brand on the website #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmac
force-pushed
the
wip/jimmac/rebrand-sans-ubuntufixes
branch
from
302bfe4
to
14af64e
Compare
9 tasks
|
This seems a bit off on lower resolutions |
razzeee
reviewed
Jun 5, 2022
| font-weight: 100 900; | ||
| font-display: swap; | ||
| font-style: oblique 0deg 10deg; | ||
| src: url("../fonts/Inter.var.woff2?v=3.19") format("woff2"); |
There was a problem hiding this comment.
"https://dl.flathub.org/repo/assets/Inter-3.19/inter.css"
@barthalion hosted Inter there for us, so it might be worth using it from the same source. But it might cause CSP problems
There was a problem hiding this comment.
I've opted to go variable font, for it is the future. A single request covering all weight needs. Looking into sharing the asset across both sites in future would be nice.
|
Other then that, clearly an improvement in my book. Especially on readability in the footer. |
- remove absolute sizing to allow to scaling Addresses #538 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #537 for more details.