Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brand: update twitter card metadata #542

Closed
wants to merge 1 commit into from
Closed

brand: update twitter card metadata #542

wants to merge 1 commit into from

Conversation

jimmac
Copy link
Contributor

@jimmac jimmac commented Jun 8, 2022

Fixes #539

mwleeds
mwleeds reviewed Jul 21, 2022
View reviewed changes
data/site.yml Outdated Show resolved Hide resolved
jimmac
jimmac commented Jul 21, 2022
View reviewed changes
Copy link
Contributor Author

@jimmac jimmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing the localhost comment

@AsciiWolf
Copy link
Collaborator

removing the localhost comment

I still see the localhost comment in site.yml.

@AsciiWolf
Copy link
Collaborator

Should this PR still be merged?

@AsciiWolf
Copy link
Collaborator

I have created a separate PR for the http -> https url change.

@AsciiWolf
Copy link
Collaborator

@jimmac Should this PR still be merged?

@AsciiWolf
Copy link
Collaborator

I have merged the following PR that seems to collide with this one.

#635

@jimmac Could you update this PR? Thanks!

@jimmac
Copy link
Contributor Author

jimmac commented Dec 1, 2023

I'm afraid my git-fu is too weak to get through 40 commit conflict resolution.

@jimmac jimmac closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwleeds mwleeds mwleeds left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

provide tags/metadata for easier sharing on Social sites
3 participants
@jimmac @AsciiWolf @mwleeds