filechooser: Fix crash when opening a file chooser with single filter set #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 14, 2023
|
Steps to reproduce in GNOME.
|
sidt4
force-pushed
the
gtk-file-filter-crash-fix
branch
from
eb3087a
to
fb6fa2f
Compare
… set 'gtk_file_filter_new_from_gvariant()' returns a 'GtkFileFilter' which is a floating reference in GTK3. Since the portal is taking ownership of the file filter through 'g_autoptr', we call 'g_object_ref_sink()' unconditionally when creating the filter instance.
GeorgesStavracas
force-pushed
the
gtk-file-filter-crash-fix
branch
from
fb6fa2f
to
ec51bea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gtk_file_filter_new_from_gvariant ()returns aGtkFileFilterwhich is a floating reference in GTK3.gtk_file_chooser_set_filter ()takes ownership of this floating reference. So, we take a ref to the filter to account for the autoptr cleanup.Note that this happens only when we have a single filter ( with 1 or more rules ) set via
gtk_file_chooser_set_filter ()in the app.