Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notification: Set correct platform data for action activation #468

Closed

Commits on Mar 2, 2024

  1. notification: Set correct platform data for action activation

    Since [1] FDO notifications can transfer a `ActivateToken` to the client
    application, we can use this token to set the correct platform data to
    get wayland startup notification working correctly.
    GNOME Shell gained the feature already in [2], so this is the last piece
    missing to get rid of the annoying "<Application> is ready" notifications,
    when clicking on a notification.
    
    We can set the platform data only for actions that are activated via
    `org.freedesktop.Application`.
    
    Fixes: flatpak#406
    
    [1] https://gitlab.freedesktop.org/xdg/xdg-specs/-/commit/b9a470004d
    [2] https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3199/
    jsparber committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    6d1d0b1 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. notification: Add platform data to ActionInvoked signal

    Apps may not implement the `org.freedesktop.Application` interface so
    they won't get the platform data. We can do a little better and add the
    platform data to the `ActionInvoked` signal.
    jsparber committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    c589c7f View commit details
    Browse the repository at this point in the history