Implement notification v2 #478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The xdg-desktop-portal notification specs v2 add a sound property for FdoNotification. We don't need to do anything if we gtk notifications are used since they are passed directly to the server.
Since [1] FDO notifications can transfer a `ActivateToken` to the client application, we can use this token to set the correct platform data to get wayland startup notification working correctly. GNOME Shell gained the feature already in [2], so this is the last piece missing to get rid of the annoying "<Application> is ready" notifications, when clicking on a notification. We can set the platform data only for actions that are activated via `org.freedesktop.Application`. Fixes: flatpak#406 [1] https://gitlab.freedesktop.org/xdg/xdg-specs/-/commit/b9a470004d [2] https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3199/
Apps may not implement the `org.freedesktop.Application` interface so they won't get the platform data. We can do a little better and add the platform data to the `ActionInvoked` signal.
We couldn't use the private GNOME Shell interface because it was missing a couple of features we need in specific instances. The private GNOME Shell interface can now also emit the ActionInvoked signal and since version v2 it's mandatory that apps specify a desktop file id so we can do the switch.
|
Isn't the gnome-shell specific bits in this MR supposed to live in xdg-desktop-portal-gnome? I'm not sure there are other implementations of the gtk notification API, nor it's stability guarantees, but I suspect we might want to drop it from xdp-gtk instead of extending it. |
|
@jadahl yes, this is an old PR. By now i moved GNOME specific code into xdp-gnome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the new version of the notification portal. This depends on GNOME Shell changes.