notification: Drop private GNOME Shell API #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since [1] FDO notifications can transfer a `ActivateToken` to the client application, we can use this token to set the correct platform data to get wayland startup notification working correctly. GNOME Shell gained the feature already in [2], so this is the last piece missing to get rid of the annoying "<Application> is ready" notifications, when clicking on a notification. We can set the platform data only for actions that are activated via `org.freedesktop.Application`. Fixes: flatpak#406 [1] https://gitlab.freedesktop.org/xdg/xdg-specs/-/commit/b9a470004d [2] https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3199/
jsparber
force-pushed
the
drop_gtk_notifications
branch
from
5d61147
to
2049cb9
Compare
Since we have the GNOME specific xdp backend we can move the private GNOME Shell things there and leave this backend implementation more generic.
jsparber
force-pushed
the
drop_gtk_notifications
branch
from
2049cb9
to
5685af4
Compare
GeorgesStavracas
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have the GNOME specific xdp backend we can move the private
GNOME Shell things there and leave this backend implementation more generic.