Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inputcapture: add support for persist_mode and restore_token #1186

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

inputcapture: add support for persist_mode and restore_token #1186

wants to merge 5 commits into from

Commits on Nov 3, 2023

  1. Share the implementation for validating persist_mode and restore_token 

    De-duplicate the two identical implementations.
    @whot
    whot committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    1b2f4f5 View commit details
    Browse the repository at this point in the history

  2. restore-token: Only add the restore_token if it's not NULL 

    For PERSIST_MODE_NONE
xdp_session_persistence_generate_and_save_restore_token() sets our token
and restore_data to NULL. Let's not try to add it to the results then.
    @whot
    whot committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    53f4826 View commit details
    Browse the repository at this point in the history

  3. tests/inputcapture: return the Response tuple from create_session 

    This can be destructured in the caller if need be but for session
checks we need the Response so we can close the Session
    @whot
    whot committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    c8978a5 View commit details
    Browse the repository at this point in the history

  4. tests/inputcapture: switch the template to ImplSession 

    So far it was good enough to pretend we're creating a session, let's
switch this over to a true session object on the bus that we can call
Close() on.
    @whot
    whot committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    e686766 View commit details
    Browse the repository at this point in the history

  5. inputcapture: Add persist_mode and restore_token 

    Identical in use to the RemoteDesktop/ScreenCast versions, this allows
us to continue a session without prompting for user interaction.
    @whot
    whot committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    b2e01a0 View commit details
    Browse the repository at this point in the history