-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SchemeSupported to the OpenURI portal #1203
base: main
Are you sure you want to change the base?
Conversation
I think this change as it is, is a bit incomplete. If an app/client is supposed to call this API, it needs to be added to the |
@xhorak also please squash your commits or split it to reasonable parts and remove the merge commit. |
@matthiasclasen Could you please check this one? |
This needs a rebase. Also, see #1375. You will have to bump version to 5. Also at the top of the XML file there is a sentence I also wonder whether this shouldn't be more generic, e.g. looking at #1313, this will make Also, |
Also, maybe this can be permission based? To address @matthiasclasen concerns? Like, first ask will popup a permission dialog, to ask whether you want to allow given application access to this information, store it for this app (app_id) and have all the following ones without any permission dialog needed in case the permission has been granted already? That would mean using the generic Access portal for this. |
@matthiasclasen we need to move forward with this. Please set some reviewer or check the PR on your own. |
To check whenever specific scheme is supported by the host.