Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl-request: Do not load properties on construction #1244

Conversation

GeorgesStavracas
Copy link
Member

The org.freedesktop.impl.portal.Request interface has no properties, and is constructed against a different object path. We don't need to fetch properties for that.

Don't do that.

Closes: #1241

The org.freedesktop.impl.portal.Request interface has no properties,
and is constructed against a different object path. We don't need to
fetch properties for that.

Don't do that.

Closes: flatpak#1241
@Sodivad
Copy link
Contributor

Sodivad commented Dec 21, 2023

Fixes the issue for me, thanks!

@GeorgesStavracas GeorgesStavracas added this pull request to the merge queue Dec 21, 2023
@GeorgesStavracas GeorgesStavracas added this to the 1.20 milestone Dec 21, 2023
Merged via the queue into flatpak:main with commit 2a8a4c4 Dec 21, 2023
4 checks passed
@GeorgesStavracas GeorgesStavracas deleted the gbsneto/dont-load-properties-impl-request branch December 21, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Triaged
Development

Successfully merging this pull request may close these issues.

xdg-desktop-portal tries to access non-existing org.freedesktop.impl.portal.Request
3 participants