Fix test failures on non gnome-terminal in GNOME #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because programs running in a non gnome-terminal belong to a .scope unit starting with app, xdg-desktop-portal assings a non empty appid to them. On the other hand, for setting permissions into the permission store, tests assume that appid is the empty string. To fix this, retrieve the appid during global setup a,d store it in a global variable. It is then available to tests, and can be passed when setting permissions. Fix 3 test failures out of 5 reported in #1278 The other failures are in python tests. Signed-off-by: Pierre Labastie <[email protected]>
Python tests assume that the appid is an empty string, which may be false when running tests on GNOME in a non gnome-terminal. Therefore, asserting that the appid is empty leads to an error. To fix this, just remove the asserts. They don't test anything since there is no independant way to retrieve the appid. Fix the remaining failures reported in #1278 Signed-off-by: Pierre Labastie <[email protected]>
|
thanks heaps, I've used your first patch in #1280 and used it as inspiration for the "proper" fix for the pytest failures (albeit with complications...) |
|
Thanks for the review @whot |
This was referenced Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because programs running in a non gnome-terminal belong to a .scope unit starting with app, xdg-desktop-portal assings a non empty appid to them. On the other hand, for setting permissions into the permission store, tests assume that appid is the empty string. To fix this, retrieve the appid during global setup a,d store it in a global variable. It is then available to tests, and can be passed when setting permissions.
Fix 3 test failures out of 5 reported in #1278
The other failures are in python tests.