Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement v2 notification spec #1298

Merged
merged 20 commits into from
Oct 17, 2024

Commits on Oct 16, 2024

  1. Configuration menu
    Copy the full SHA
    9aa3737 View commit details
    Browse the repository at this point in the history
  2. notification: Accept icons as file descriptor

    Icons could potentially be really big in size. Instead of passing the data via
    GBytesIcon (as part of the D-Bus message) allow passing a
    sealed fd created with `memfd_create()`
    jsparber committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a43693a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    40770d2 View commit details
    Browse the repository at this point in the history
  4. notification: Add new sound property

    This property allows applications to specify a sound to be played
    whenever the notification is displayed. The format used is inspired by
    the serialized from of GIcons.
    jsparber committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    eafe091 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0932ee7 View commit details
    Browse the repository at this point in the history
  6. notification: Add new property markup-body to support markup

    The `markup-body` property allows applications to set markup on the
    body.
    The used markup is a subset of html limted to <b>, <i> and <a>.
    jsparber committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    19774be View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    297b5a8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    20a2e63 View commit details
    Browse the repository at this point in the history
  9. notification: Add display-hint property

    This property allows apps to specify how the notification is displayed.
    jsparber committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    9c617f1 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    6a4b280 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    6e895bc View commit details
    Browse the repository at this point in the history
  12. notification: Add platform-data to ActionInvoked signal

    We need to hand out the activation token for XDG Activation in some way.
    I think it's pretty nice that we can just add the same platform data as
    used for DBus Activation to the ActionInvoked signal.
    jsparber committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    077ff6e View commit details
    Browse the repository at this point in the history
  13. notification: Add category property

    The category allows the notification server to handle specific
    notification different. E.g. calls notifications.
    jsparber committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    eb8c1f4 View commit details
    Browse the repository at this point in the history
  14. notification: Add purpose property for buttons

    The purpose for a button allows the notification server to style the
    button specially and know the purpose of the button.
    jsparber committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a5fac9b View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    c2ae443 View commit details
    Browse the repository at this point in the history
  16. notification: Add supported-options property

    Let applications query supported options for category and button purpose.
    jsparber committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    2baa5b8 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    cb08bd3 View commit details
    Browse the repository at this point in the history
  18. notification: Introduce version property for backend impl interface

    We need to make sure that the backend supports new features introduced
    to the frontend. This ensure backwards compatibility with older backend
    versions.
    jsparber committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4b1a2e3 View commit details
    Browse the repository at this point in the history
  19. notification: Ensure backwards compatibility with old backends

    We want to support old backends ensure we filter out properties that
    were introduced in never versions.
    In the case of the file-descriptor icon we can translate it to a bytes
    icon to increase compatibility.
    jsparber committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    2e8860a View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. notification: Deprecate bytes option for icons

    Since we now have the option to give a file-descriptor there is no need
    for moving binary data across D-Bus. This also ensures backwards
    compatibility by converting the icon property's `bytes` option to
    the `file-descriptor` option.
    jsparber committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    1e65575 View commit details
    Browse the repository at this point in the history