Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniformize application as app #1327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/background.c
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,7 @@ handle_request_background_in_thread_func (GTask *task,
subtitle = g_strdup_printf (_("%s requests to be started automatically and run in the background."), info ? g_app_info_get_display_name (info) : id);
else
subtitle = g_strdup_printf (_("%s requests to run in the background."), info ? g_app_info_get_display_name (info) : id);
body = g_strdup (_("The ‘run in background’ permission can be changed at any time from the application settings."));
body = g_strdup (_("The ‘run in background’ permission can be changed at any time from the app settings."));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this referring to the settings for the app, or to Applications settings found in Settings apps?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Application settings found in Settings app. But what about other DEs on this and "app" name?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is the case, then it would be good to have this be "applications settings" since it would be referring to general settings.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this worse than what is it right now? Should we just go ahead and merge this?

At the end of the day, this is generic code shared by all environments so being more specific seems out of the question.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just "application settings" is still confusing in my opinion. However, that’s less a problem if all DEs give the background permission automatically like in GNOME.


g_debug ("Calling backend for background access for: %s", id);

Expand Down
2 changes: 1 addition & 1 deletion src/location.c
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@ handle_start_in_thread_func (GTask *task,
g_assert (xdp_app_info_is_host (request->app_info));
app_id = g_strdup ("");
title = g_strdup (_("Grant Access to Your Location?"));
subtitle = g_strdup (_("An application wants to use your location."));
subtitle = g_strdup (_("An app wants to use your location."));
}

body = _("Location access can be changed at any time from the privacy settings.");
Expand Down
4 changes: 2 additions & 2 deletions src/screenshot.c
Original file line number Diff line number Diff line change
Expand Up @@ -262,8 +262,8 @@ handle_screenshot_in_thread_func (GTask *task,
* apps for which an app ID can't be determined.
*/
g_assert (xdp_app_info_is_host (request->app_info));
title = g_strdup (_("Allow Applications to Take Screenshots?"));
subtitle = g_strdup (_("An application wants to be able to take screenshots at any time."));
title = g_strdup (_("Allow Apps to Take Screenshots?"));
subtitle = g_strdup (_("An app wants to be able to take screenshots at any time."));
}

body = _("This permission can be changed at any time from the privacy settings.");
Expand Down
4 changes: 2 additions & 2 deletions src/wallpaper.c
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,8 @@ handle_set_wallpaper_in_thread_func (GTask *task,
*/
g_assert (xdp_app_info_is_host (request->app_info));
app_id = g_strdup ("");
title = g_strdup (_("Allow Applications to Set Backgrounds?"));
subtitle = g_strdup (_("An application is requesting to be able to change the background image."));
title = g_strdup (_("Allow Apps to Set Backgrounds?"));
subtitle = g_strdup (_("An app is requesting to be able to change the background image."));
}
body = _("This permission can be changed at any time from the privacy settings.");

Expand Down
Loading