Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested both by adding all
.xml
interface files to a Qt project viaqt_add_dbus_interface
, and throughmeson test -C _build
.Two tests are failing, attached for posterity:
testlog.txt
They don't seem to be introduced by this PR though, as I can still reproduce them on the previous commit, even after a clean rebuild.
Note that
Lockdown.xml
still errors as its property names arekebab-cased
instead ofsnake_cased
, which Qt considers as invalid.Also does minor formatting changes for consistency:
type=
beforename=