portal-impl: Use fallback portals for Settings as well #1358
Conversation
|
I like this. I just spent an hour or two figuring out why GNOME Software Center refused to go into dark mode under XFCE: https://tommie.github.io/a/2024/08/xfce-gnome-dark-mode Turns out it was because Settings requires the However, I'm curious why the UseIn is deprecated. Is there a replacement? Assuming one machine supports multiple desktop environments for users to choose from, it seems like a global configuration isn't expressive enough. The workaround is a user-specific configuration. Forcing users to create a config file feels like a regression. |
Agreed, and that's why there's a per-desktop-environment configuration (which supersedes |
Oh, sorry, I missed the part where it said that the prefix is matched against the desktop name. So that's the replacement. Thanks for the link! |
|
Apologies for the tangential noise on this PR. Just to close this off: Ubuntu 24.04 is unlucky to have xfce4-session 4.18.3, while the new config file is in 4.18.4. 4.18.4 is in Debian testing. I also found your https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050802. So I filed https://bugs.launchpad.net/ubuntu/+source/xfce4-session/+bug/2076999. |
|
The change seems fine to me but I'd like @ebassi opinion on it. |
liskin
force-pushed
the
settings-fallback
branch
from
2e159e1
to
36ef9be
Compare
|
Rebased on top on today's main and applied the suggestions. |
There was a problem hiding this comment.
Superficial comments only, but I also would like to hear what @ebassi thinks of it
liskin
force-pushed
the
settings-fallback
branch
from
36ef9be
to
52f5814
Compare
|
LGTM and ebassi approves |
Since 1.18.2, we have a hardcoded fallback to xdg-desktop-portal-gtk as a last resort if no other portal is defined by a configuration file. This fallback mechanism, however, isn't implemented for the org.freedesktop.impl.portal.Settings interface. The consequence is that everything seems to work just fine, but user preferences like color scheme are ignored in applications that use the portal API to retrieve them (not just flatpak apps, also libadwaita apps). That comes as a surprise to users; and since the portal stuff otherwise works fine, it's not entirely straightforward to figure out that configuring portal.conf would fix it. I believe that if find_portal_implementation implements fallbacks, so should find_all_portal_implementations, for consistency and to avoid surprises. The fallback logic this commit implements closely resembles the logic in find_portal_implementation: we don't look for fallbacks if there is a portal configured in portals.conf (or if portals.conf explicitly says there should be none), and we only use the x-d-p-gtk as a last resort if we haven't found any impl(s) using the legacy UseIn key. (The above should be a self-contained description but there's some additional thoughts at flatpak#1199 (comment)) Fixes: d18c563 ("portal-impl: Hard-code x-d-p-gtk as a last-resort fallback") Related: flatpak#1102
GeorgesStavracas
force-pushed
the
settings-fallback
branch
from
52f5814
to
d717078
Compare
Since 1.18.2, we have a hardcoded fallback to xdg-desktop-portal-gtk as a last resort if no other portal is defined by a configuration file. This fallback mechanism, however, isn't implemented for the org.freedesktop.impl.portal.Settings interface.
The consequence is that everything seems to work just fine, but user preferences like color scheme are ignored in applications that use the portal API to retrieve them (not just flatpak apps, also libadwaita apps). That comes as a surprise to users; and since the portal stuff otherwise works fine, it's not entirely straightforward to figure out that configuring portal.conf would fix it.
I believe that if
find_portal_implementationimplements fallbacks, so shouldfind_all_portal_implementations, for consistency and to avoid surprises.The fallback logic this commit implements closely resembles the logic in
find_portal_implementation: we don't look for fallbacks if there is a portal configured in portals.conf (or if portals.conf explicitly says there should be none), and we only use the x-d-p-gtk as a last resort if we haven't found any impl(s) using the legacy UseIn key.(The above should be a self-contained description but there's some additional thoughts at #1199 (comment))
Fixes: d18c563 ("portal-impl: Hard-code x-d-p-gtk as a last-resort fallback")
Related: #1102