Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screen-cast: Add textual context hint #1379

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tytan652
Copy link
Contributor

@tytan652 tytan652 commented Jun 20, 2024

Adds an optional argument to display a textual hint on the Screen Cast selection dialog.

When a software like OBS Studio has multiple Screen Cast session, the user has no way to know from which session the dialog comes from when prompted at start.
This new argument allows to mitigate that if used by the implementation.

@tytan652
Copy link
Contributor Author

tytan652 commented Jun 20, 2024

Just found about #939 but the author didn't rebased it since a while…

Edit: The key difference is that this PR does not try to replace any formatted message from the implementation but allows to add a hint.

@Mikenux
Copy link

Mikenux commented Jun 20, 2024

How a session name would be useful, because when these prompts are displayed, they list all available sources (e.g. when selecting a window). Or is it in the case there are multiple open OBS windows?

@tytan652
Copy link
Contributor Author

tytan652 commented Jun 20, 2024

This is not a session name and this is not about shown sources.

Example: The user have an application with 3 screen cast session (e.g. OBS Screen Capture source), if 1, 2 or 3 show up a prompt at start, the user has no idea for which session the prompt is for.

The context hint shown (for OBS the name of the source) on the prompt would allow the user to know for which session is the prompt, allowing him to chose the source. Rather than dismissing all of them and check which session didn't get restored.

@Mikenux
Copy link

Mikenux commented Jun 21, 2024

The problem with text hints from an app to display in the portal UI is that they are unreliable. In the case of the screencast portal:

  • No guarantee that the selected source will be assigned to the corresponding source in the app UI.
  • The user must be able to check if said source exists in the app UI. Possible for the user, but is this a process we want for them, especially when there are multiple prompts that may cover the app UI?
  • A hint can be used to prompt the user to request a specific source. This depends on how things are requested in the portal UI and how the user remembers their session.

Not knowing how users will take things, I tend to say not to use such hints. It is best to contact designers to solve such problem.

@tytan652
Copy link
Contributor Author

It is best to contact designers to solve such problem.

Feel free to do so, I can't endlessly add stuff to work on my plate (and creating design discussions and keeping them moving is work).

@Mikenux
Copy link

Mikenux commented Jun 26, 2024

I can at least open a design issue on the GNOME tracker.

However, before that, I would like to know if the following alternative without a hint is reasonably feasible without too many changes and solves the problem: have a way to account for multiple tokens so that we can present only one window to restore the sources (e.g. "Select missing sources").

If this is not feasible without big changes or if it is not a solution to the problem at all, then I will be more willing to open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

2 participants