XdpAppInfo refactoring, Part 3 #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swick
force-pushed
the
wip/xdp-app-info-part3
branch
2 times, most recently
from
ea9d446
to
a435003
Compare
|
Rebased the last few commits of the XdpAppInfo refactoring on part 2. |
swick
force-pushed
the
wip/xdp-app-info-part3
branch
from
a435003
to
b52915b
Compare
|
Gentle ping. This one should be pretty straight forward. |
For example, for flatpak, the sub-app-id must be a valid app id in itself and also have the app-id as a prefix, with a dot as separator. Host apps don't have any restrictions. The flatpak_is_valid_name function has been copied from the flatpak project.
For flatpak apps, the dynamic launcher desktop file id shall be a valid flatpak id plus the .desktop part. Use the newly introduced xdp_app_info_is_valid_sub_app_id function to make sure this is the case and allow other app kinds to add similar restrictions.
GeorgesStavracas
force-pushed
the
wip/xdp-app-info-part3
branch
from
b52915b
to
31a65a2
Compare
GeorgesStavracas
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #1369.