Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Translate pytest exit status to Meson/ginsttest-runner convention [pytest approach] #1578

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

swick
Copy link
Contributor

@swick swick commented Jan 17, 2025

Alternative to #1577 which implements it directly in the pytest conftest which should work transparently for build and installed tests.

/cc @smcv

Meson and ginsttest-runner expect the Automake convention and will
report a failure instead of a skipped test otherwise.

Resolves: flatpak#1575
@swick swick force-pushed the wip/pytest-skipped-return-code branch from f8b990c to cc1e924 Compare January 17, 2025 13:46
@smcv smcv self-requested a review January 17, 2025 16:54
Copy link
Collaborator

@smcv smcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is better. I'll try it with autopkgtest.

@smcv smcv added this pull request to the merge queue Jan 20, 2025
Merged via the queue into flatpak:main with commit 229874f Jan 20, 2025
5 checks passed
@smcv smcv mentioned this pull request Jan 20, 2025
@GeorgesStavracas GeorgesStavracas added this to the 1.20 milestone Jan 20, 2025
@GeorgesStavracas GeorgesStavracas added the tests Test suite label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Test suite
Projects
No open projects
Status: Triaged
Development

Successfully merging this pull request may close these issues.

3 participants