Skip to content

Commit

Permalink
Removes whitespaces
Browse files Browse the repository at this point in the history
Signed-off-by: Flavia Beo <[email protected]>
  • Loading branch information
flaviabeo committed Oct 31, 2024
1 parent bfdaac3 commit 36fee51
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
6 changes: 3 additions & 3 deletions tests/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ def test_get_pooling_config():
)

minilm_pooling_config = minilm_model_config._init_pooler_config(
pooling_type=None,
pooling_type=None,
pooling_norm=None,
pooling_returned_token_ids=None,
pooling_softmax=None,
Expand All @@ -139,13 +139,13 @@ def test_get_pooling_config_from_args():
revision=None)

minilm_pooling_config = minilm_model_config._init_pooler_config(
pooling_type='CLS',
pooling_type='CLS',
pooling_norm=True,
pooling_returned_token_ids=None,
pooling_softmax=None,
pooling_step_tag_id=None)

assert minilm_pooling_config.pooling_norm
assert minilm_pooling_config.pooling_norm == True

Check failure on line 148 in tests/test_config.py

View workflow job for this annotation

GitHub Actions / ruff (3.8)

Ruff (E712)

tests/test_config.py:148:12: E712 Avoid equality comparisons to `True`; use `if minilm_pooling_config.pooling_norm:` for truth checks

Check failure on line 148 in tests/test_config.py

View workflow job for this annotation

GitHub Actions / ruff (3.9)

Ruff (E712)

tests/test_config.py:148:12: E712 Avoid equality comparisons to `True`; use `if minilm_pooling_config.pooling_norm:` for truth checks

Check failure on line 148 in tests/test_config.py

View workflow job for this annotation

GitHub Actions / ruff (3.10)

Ruff (E712)

tests/test_config.py:148:12: E712 Avoid equality comparisons to `True`; use `if minilm_pooling_config.pooling_norm:` for truth checks

Check failure on line 148 in tests/test_config.py

View workflow job for this annotation

GitHub Actions / ruff (3.11)

Ruff (E712)

tests/test_config.py:148:12: E712 Avoid equality comparisons to `True`; use `if minilm_pooling_config.pooling_norm:` for truth checks

Check failure on line 148 in tests/test_config.py

View workflow job for this annotation

GitHub Actions / ruff (3.12)

Ruff (E712)

tests/test_config.py:148:12: E712 Avoid equality comparisons to `True`; use `if minilm_pooling_config.pooling_norm:` for truth checks
assert minilm_pooling_config.pooling_type == PoolingType.CLS.name


Expand Down
1 change: 0 additions & 1 deletion vllm/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,6 @@ def __init__(
self.hf_config = get_config(self.model, trust_remote_code, revision,
code_revision, rope_scaling, rope_theta,
config_format)
self.bert_config = self._get_bert_config()
self.hf_text_config = get_hf_text_config(self.hf_config)
self.bert_config = self._get_bert_config()
self.hf_image_processor_config = get_hf_image_processor_config(
Expand Down

0 comments on commit 36fee51

Please sign in to comment.