Editable elements are a repaint boundary (#396)

* EditableTextLine is a repaint boundary * Repaint editor when floating cursor changes
fleather-editor · Aug 16, 2024 · 7b21eef · 7b21eef
1 parent e395141
commit 7b21eef
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 0 deletions.
diff --git a/packages/fleather/lib/src/rendering/editable_text_block.dart b/packages/fleather/lib/src/rendering/editable_text_block.dart
@@ -273,6 +273,9 @@ class RenderEditableTextBlock extends RenderEditableContainerBox
 
   // End RenderEditableBox implementation
 
+  @override
+  bool isRepaintBoundary = true;
+
   @override
   void detach() {
     _painter?.dispose();

diff --git a/packages/fleather/lib/src/rendering/editable_text_line.dart b/packages/fleather/lib/src/rendering/editable_text_line.dart
@@ -519,6 +519,9 @@ class RenderEditableTextLine extends RenderEditableBox {
 
   bool _attachedToCursorController = false;
 
+  @override
+  bool isRepaintBoundary = true;
+
   @override
   void attach(covariant PipelineOwner owner) {
     super.attach(owner);

diff --git a/packages/fleather/lib/src/rendering/editor.dart b/packages/fleather/lib/src/rendering/editor.dart
@@ -862,6 +862,7 @@ class RenderEditor extends RenderEditableContainerBox
       _floatingCursorRect = null;
       _cursorController.setFloatingCursorTextPosition(null);
     }
+    markNeedsPaint();
   }
 
   void _paintFloatingCursor(PaintingContext context, Offset offset) {

diff --git a/packages/fleather/lib/src/rendering/embed_proxy.dart b/packages/fleather/lib/src/rendering/embed_proxy.dart
@@ -9,6 +9,9 @@ import 'editable_box.dart';
 class RenderEmbedProxy extends RenderProxyBox implements RenderContentProxyBox {
   RenderEmbedProxy({RenderBox? child}) : super(child);
 
+  @override
+  bool isRepaintBoundary = true;
+
   @override
   List<TextBox> getBoxesForSelection(TextSelection selection) {
     if (selection.isCollapsed) {