Fix wrong bounding box for text line in block

[Amir-P]

Fixes #143 and changes hit test in text line to prevent trailing empty space from triggering rich text hit test.

Before:

After:

[codecov]

Codecov Report

Merging #144 (bce3a87) into master (3590e3d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   84.01%   84.02%           
=======================================
  Files          60       60           
  Lines        9348     9351    +3     
=======================================
+ Hits         7854     7857    +3     
  Misses       1494     1494           

Impacted Files	Coverage Δ
...kages/fleather/lib/src/rendering/editable_box.dart	51.26% <100.00%> (-0.41%)	⬇️
...fleather/lib/src/rendering/editable_text_line.dart	71.80% <100.00%> (+0.30%)	⬆️

[amantoux]

@Amir-P I think this break the behavior designed in PR #77

[Amir-P]

@Amir-P I think this break the behavior designed in PR #77

Can't we address that issue when hit testing? Also why it's not a problem with outside of block text lines? @amantoux

[amantoux]

@Amir-P I think this break the behavior designed in PR #77

Can't we address that issue when hit testing? Also why it's not a problem with outside of block text lines? @amantoux

Hey @Amir-P, were you able to dig a little further on this?

[Amir-P]

Hey @Amir-P, were you able to dig a little further on this?

Not yet. I'll get to it tomorrow. Will let you know. @amantoux

[Amir-P]

There is definitely a problem with hit testing but the fix at #77 is only solving problem for blocks and causes another issue (#143). We need to merge this and then find a way for fixing underlying problem. WDYT? @amantoux

A normal text line with link on master branch showing the hit test problem:

Update:

After testing RichText widget expanded horizontally, I found out that this behavior is from RichText widget.

RichText(
  text: TextSpan(children: [
    TextSpan(text: 'Test'),
    TextSpan(text: 'with'),
    TextSpan(
        text: 'Link',
        mouseCursor: SystemMouseCursors.click,
        recognizer: TapGestureRecognizer()
          ..onTap = () {
            print('Tap');
          }),
  ]),
);

RichText(
  text: TextSpan(children: [
    TextSpan(text: 'Test'),
    TextSpan(text: 'with'),
    TextSpan(
        text: 'Link',
        mouseCursor: SystemMouseCursors.click,
        recognizer: TapGestureRecognizer()
          ..onTap = () {
            print('Tap');
          }),
  ]),
);

This is a weird behavior to me. I think we have two options now:

1. Extend RichText and fix the hitTest problem
2. Limit the bounding box for both lines and blocks and fix problem with alignment and possibly other attributes that gets affected by limited bounding box.

[amantoux]

@Amir-P Either solution works but if 2. is easily acheivable, I think we should go for this one

[Amir-P]

@Amir-P Either solution works but if 2. is easily acheivable, I think we should go for this one

Yeah, after experimenting with RichText and TextPainter, changes for option 1 is a lot. I think option 2 is safer. I'll push another commit on this branch to make lines bounding box like blocks and will update the issue description too. Then will fix the alignment issue.

[Amir-P]

Finally, I've decided to keep text lines constraints unchanged and instead check if hit test position is in text boxes. I think it's ready for review. @amantoux

[amantoux]

LGTM! Thanks @Amir-P