Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generated files from VCS #410

Closed
wants to merge 1 commit into from

Conversation

amantoux
Copy link
Member

No description provided.

@amantoux amantoux requested a review from Amir-P August 19, 2024 07:00
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.19%. Comparing base (7f965d0) to head (abdfd26).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #410      +/-   ##
==========================================
+ Coverage   87.91%   88.19%   +0.28%     
==========================================
  Files          62       62              
  Lines       10332    10575     +243     
==========================================
+ Hits         9083     9327     +244     
+ Misses       1249     1248       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amantoux
Copy link
Member Author

amantoux commented Aug 22, 2024

Canceling beacause files are generated by running flutter pub get from the fleather directory and will therefore not be generated when building or getting dependencies for any app implementing Fleather. This would cause some extra burden for implementors

@amantoux amantoux closed this Aug 22, 2024
@amantoux amantoux reopened this Aug 22, 2024
@amantoux amantoux closed this Aug 22, 2024
@amantoux amantoux deleted the remove_generated_files_from_vcs branch August 22, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant