FOGL-9354 Prevent Service Crash on Restart When Not Connected to OPC UA Server #50
Conversation
Signed-off-by: Ashwini Kumar Pandey <[email protected]>
| { | ||
| subscriptionVariables.clear(); | ||
| m_assetPathNames.clear(); | ||
| m_client->Disconnect(); |
There was a problem hiding this comment.
put this inside an if (m_client) test
There was a problem hiding this comment.
The following code is executed under the m_connected flag, which guarantees that m_client is never null at this point. However, it’s important to note that m_client (of type UaClient) is not exception-safe. The Disconnect() method can throw exceptions, and since Disconnect() is called in delete m_client, this raises a risk of memory leaks if an exception occurs during disconnection.
Currently, our implementation ensures that the process exits after invoking OPCUA::stop(), which protects us from memory leaks under normal circumstances.
If you agree i would like to add this finding as comments here ..
| } | ||
| if (m_client) | ||
| { | ||
| delete m_client; |
There was a problem hiding this comment.
Set m_client back to NULL so that other tests will fail
Signed-off-by: Ashwini Kumar Pandey <[email protected]>
No description provided.