Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run bash scripts (#!/bin/bash) #24470

Open
14 of 20 tasks
noahtalerman opened this issue Dec 6, 2024 · 0 comments
Open
14 of 20 tasks

Run bash scripts (#!/bin/bash) #24470

noahtalerman opened this issue Dec 6, 2024 · 0 comments
Assignees
Labels
customer-cisneros customer-leiden #g-orchestration Orchestration product group :product Product Design department (shows up on 🦢 Drafting board) story A user story defining an entire feature

Comments

@noahtalerman
Copy link
Member

noahtalerman commented Dec 6, 2024

Goal

User story
As an IT admin,
I want to run scripts with #!/bin/bash on macOS/Linux
so that I don't have to rewrite my existing bash scripts to prevent them from failing.

Key result

Deliver prioritized customer request

Original requests

Context

Changes

Product

  • UI changes: Figma
  • CLI (fleetctl) usage changes: No changes
  • YAML changes: No changes
  • REST API changes: No changes
  • Fleet's agent (fleetd) changes: No changes
  • Activity changes: No changes
  • Permissions changes: No changes
  • Changes to paid features or tiers: No changes
  • Transparency changes: No changes
  • First draft of test plan added
  • Other reference documentation changes: Update scripts guide
  • Once shipped, requester has been notified
  • Once shipped, dogfooding issue has been filed

Engineering

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

  • Requires load testing: TODO
  • Risk level: Low / High TODO
  • Risk description: TODO

Test plan

  1. Upload a script that begins with #!/bin/bash and contains bash-specific features (e.g. uses arrays)
    • Run the script on a macOS host
    • Run the script on a Linux host
  2. Upload the same script, but without #!/bin/bash on the first line.
    • Try running again; should fail because it runs using #!/bin/sh

Testing notes

Confirmation

  1. Engineer (@____): Added comment to user story confirming successful completion of test plan.
  2. QA (@____): Added comment to user story confirming successful completion of test plan.
@noahtalerman noahtalerman added story A user story defining an entire feature :product Product Design department (shows up on 🦢 Drafting board) #g-endpoint-ops Endpoint ops product group Epic DO NOT USE. Auto-created by ZenHub, cannot be disabled. and removed Epic DO NOT USE. Auto-created by ZenHub, cannot be disabled. labels Dec 6, 2024
@noahtalerman noahtalerman removed the :product Product Design department (shows up on 🦢 Drafting board) label Dec 6, 2024
@noahtalerman noahtalerman added #g-orchestration Orchestration product group :product Product Design department (shows up on 🦢 Drafting board) and removed #g-endpoint-ops Endpoint ops product group labels Dec 20, 2024
iansltx added a commit that referenced this issue Jan 15, 2025
@xpkoala xpkoala assigned sharon-fdm and xpkoala and unassigned rachaelshaw Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-cisneros customer-leiden #g-orchestration Orchestration product group :product Product Design department (shows up on 🦢 Drafting board) story A user story defining an entire feature
Development

No branches or pull requests

5 participants