Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#24470 API design: Run bash scripts #25382

Closed
wants to merge 1 commit into from

Conversation

rachaelshaw
Copy link
Member

For #24470

@iansltx
Copy link
Member

iansltx commented Jan 13, 2025

Do we even need an API for this change? We can detect this via the shebang, and enforce the convention of "if you want bash then ask for it in the shebang" just like we do for zsh.

@@ -8548,13 +8548,15 @@ Deletes an existing script.
"id": 1,
"team_id": null,
"name": "script_1.sh",
"interpreter": "bash",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev note:

  • This key is not present for Windows (.ps1) scripts
  • Either "sh", "zsh", or "bash"

@rachaelshaw
Copy link
Member Author

Do we even need an API for this change? We can detect this via the shebang, and enforce the convention of "if you want bash then ask for it in the shebang" just like we do for zsh.

Good point! Cutting the interpreter text from the UI to make this iteration smaller. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants